New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#214, rt-template with in-place child component #216

Open

yatra9 wants to merge 1 commit into wix-incubator:gh-pages from yatra9:gh-pages

+101 −7

yatra9 commented Mar 7, 2017

This implements #214

I add tests, and modified README also (but, review required, because I'm not a native English speaker)


          wix-incubator#214, rt-template with in-place child component

05b1ab5

Contributor

nippur72 commented Mar 8, 2017

great, I have two suggestions:

can we rename in-place with something more intuitive, e.g. component ? Or perhaps we could have a new attribute <rt-prop>:

<rt-template prop="mybutton" component>
   <button>my</button>
</rt-template>

<!-- or -->

<rt-prop name="mybutton">
   <button>my</button>
</rt-prop>

just for code styling, use string interpolation when throwing errors:

throw RTCodeError.build(context, child, `'rt-template' should have a '${templateNode_PropAttr}' attribute`);

instead of the more verbose

throw RTCodeError.build(context, child, "'rt-template' should have a " + templateNode_PropAttr + ' attribute');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet